Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulndb column name in getVulnerabilityAliases method #2428

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

mehab
Copy link
Contributor

@mehab mehab commented Jan 31, 2023

Signed-off-by: mehab [email protected]

Description

This change is updating the column name for getting vulnerability aliases from vulndb

Current behaviour
The current query for getting vulnerability aliases for vulndb as source in the getVulnerabilityAliases method is query = pm.newQuery(VulnerabilityAlias.class, "vulnDb== :vulnDb"); which has column name invalid.

Expected behaviour
The correct id column for vulndb id is vulnDbId and thus the query should be query = pm.newQuery(VulnerabilityAlias.class, "vulnDbId == :vulnDb"); so that there is no error.

Addressed Issue

Additional Details

Checklist

  • [ x] I have read and understand the contributing guidelines
  • [x ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the defect Something isn't working label Jan 31, 2023
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mehab! 🙌

If my understanding is correct, this bug is currently breaking the VulnDB integration.

@msymons A candidate for 4.7.1?

@nscuro nscuro merged commit eafe21e into DependencyTrack:master Jan 31, 2023
@nscuro nscuro added this to the 4.7.1 milestone Jan 31, 2023
@nscuro nscuro mentioned this pull request Jan 31, 2023
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants