Enable to set unresolved license for license policy #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nscuro
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Thanks for the PR @rbt-mm!
I'm unsure about the undefinedLicense part. Given this policy condition is about resolved licenses (as in, resolved SPDX license), "undefined" may be a bit misleading. Components can have unresolved licenses as well.
Perhaps using unresolved instead of undefinedLicenses would make this more clear?
|
Yeah, I agree that it would be more clear if it was named I will change the names in the backend and frontend. |
rbt-mm
changed the title
Signed-off-by: RBickert <[email protected]>
Signed-off-by: RBickert <[email protected]>
rbt-mm
force-pushed
the
master-set-license-policy-condition-to-null
branch
from
40364f0 to
d111f5b
Compare
nscuro
approved these changes
Dec 6, 2022
mulder999
pushed a commit
to mulder999/dependency-track
that referenced
this pull request
Dec 23, 2022
…2214) * Enable to set undefined license for license policy Signed-off-by: RBickert <[email protected]> * Change `undefinedLicense` to `unresolved` Signed-off-by: RBickert <[email protected]> Signed-off-by: RBickert <[email protected]> Closes DependencyTrack#1518 Signed-off-by: mulder999 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you want to set up a license policy where the license is blank or null, it is currently only possible by creating a license policy which includes every single license. This is tedious to set up and needs to be maintained if new licenses are added.
To simplify setting up this license policy, it is now possible to choose
unresolvedas the value for a policy condition. This condition then checks, if a component does not have a license.Addressed Issue
#1518
Additional Details
Frontend PR
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly