Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving indices to their own initializer #2201

Closed
wants to merge 1 commit into from

Conversation

officerNordberg
Copy link
Contributor

Signed-off-by: Drew Thompson [email protected]

Description

Discovered while troubleshooting #2104

Addressed Issue

Put reindexing of Lucene Indices after the Event system has been initialized

Checklist

  • [x ] I have read and understand the contributing guidelines
  • [ x] This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@officerNordberg
Copy link
Contributor Author

@nscuro I don't understand the Codeacy issue. If someone else can make this fix I'd appreciate it. This project is too hard to work on.

@stevespringett
Copy link
Member

@officerNordberg Don't worry about the Codacy issue. @nscuro we should likely remove it since we've moved on to Lift anyway.

@nscuro
Copy link
Member

nscuro commented Nov 29, 2022

Thanks for the PR @officerNordberg!

Looks like it conflicts with #2200. @syalioune, as your PR is a superset of this one, and still a WIP, I'm going to merge this first. Please rebase / merge accordingly.

@stevespringett I have suspended Codacy on the org level.

@nscuro
Copy link
Member

nscuro commented Nov 29, 2022

@stevespringett Saw just now that the PR targets the 4.6.x branch. Do we want a bugfix release for this?

@stevespringett
Copy link
Member

@nscuro this should likely go into 4.7

@officerNordberg
Copy link
Contributor Author

Sent it to the wrong place, duplicated @syalioune 's work

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Enable fuzzy CPE matching' options lead to I/O Exception in the FuzzyVulnerableSoftwareSearchManager
3 participants