grafana: replace broken heap usage gauge #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentijn Scholten <[email protected]>
valentijnscholten
changed the title
|
|
|
For future reference: This is latest state of variable support in Transformations: grafana/grafana#46428 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current heap usage gauge is not working correctly. This is because Grafana doesn't support variables in data transformations.
And we're using a transformation to dynamically set the Max value of the gauge, but this fails when using the $instance variable. It only works if the instance name is hardcoded (or left out). It currently is set hardcoded to
apiserver:8080which probably won't work for most realworld deployments.This PR switches from a gauge to two stat panels giving similar information. The colours are always green as again if we wanted thresholds and a max value, we would run into the same problems.
If you want colours for heap usage, you can use the micrometer dashboard which shows the percentage of heap used in green - orange - red styles.
Signed-off-by: Valentijn Scholten [email protected]