Docker: Add optional EXTRA_JAVA_OPTIONS environment variable #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Valentijn Scholten <[email protected]>
Signed-off-by: Valentijn Scholten <[email protected]>
valentijnscholten
force-pushed
the
extra-java-options
branch
from
9888632 to
2630d94
Compare
nscuro
reviewed
Oct 12, 2022
Signed-off-by: Valentijn Scholten <[email protected]>
nscuro
approved these changes
Oct 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful to pass extra JVM options into the DT Java process.
While it is possible to override the
JAVA_OPTIONS, this would mean the existing default value fromDockerfilehas to be copied and maintained.This PR adds a
EXTRA_JAVA_OPTIONSenvironment variable that can be specified at runtime, while benefitting from the existing defaults in theDockerfile.