Issue #1622 DefectDojo integration reimport enhancement - Part 2 #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend code change is now in DependencyTrack/frontend#179 |
| LOGGER.debug("Found existing test Id: " + testId); | ||
| if (testId.equals("")) { | ||
| client.uploadDependencyTrackFindings(apiKey.getPropertyValue(), engagementId.getPropertyValue(), payload); | ||
| } else { | ||
| client.reimportDependencyTrackFindings(apiKey.getPropertyValue(), engagementId.getPropertyValue(), payload, testId); | ||
| } | ||
| } else if (Boolean.parseBoolean(globalReimportEnabled.getPropertyValue())) { |
There was a problem hiding this comment.
Can we merge the two branches of the if that perform REimport? The second one currently does not check for an empty test id.
There was a problem hiding this comment.
Good point on make the code more readable - thank you. The change is now in @valentijnscholten
Signed-off-by: Sam Li2 <[email protected]> Signed-off-by: Sam Li2 <[email protected]>
…esponding frondend code change Signed-off-by: Sam Li2 <[email protected]> Signed-off-by: Sam Li2 <[email protected]>
…onstant DEFECTDOJO_REIMPORT_ENABLED Signed-off-by: Sam Li2 <[email protected]> Signed-off-by: Sam Li2 <[email protected]>
Signed-off-by: Sam Li2 <[email protected]>
nscuro
approved these changes
Jun 27, 2022
|
thanks @yangsec888 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global reimport flag support per valentijnscholten suggestion. Note a separate PR on GUI will be sent in 'frontend' repo.