-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit PORTFOLIO alert to project does not work for audit changes #975
Comments
Hello @stevespringett @nscuro |
We have the same issue , we are spammed by other projects alerts |
Did not have this on the radar, thanks for bringing it up. Just raised a PR that should address it. @stevespringett I don't think this justifies a bugfix release, so I'd schedule this for 4.7. Or would you prefer this to be released sooner? |
Thanks all. @nscuro lets target 4.7 |
to now also include the following subjects: * `PolicyViolationIdentified` * `AnalysisDecisionChange` * `ViolationAnalysisDecisionChange` Fixes DependencyTrack#975 Signed-off-by: nscuro <[email protected]>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
to now also include the following subjects: * `PolicyViolationIdentified` * `AnalysisDecisionChange` * `ViolationAnalysisDecisionChange` Fixes DependencyTrack#975 Signed-off-by: nscuro <[email protected]>
Current Behavior:
This is similar to #616. Limiting PORTFOLIO alerts to projects does not work for PROJECT_AUDIT_CHANGE notifications like suppressing findings and setting their analysis state. Changing a finding status for a project sends the notification via all alerts that include PROJECT_AUDIT_CHANGE not depending on the configured project limits.
Steps to Reproduce:
Define two projects and respective PORTFOLIO alerts limited to the projects with PROJECT_AUDIT_CHANGE selected. Changing a finding status for one of the projects results in a notification sent for both projects.
Expected Behavior:
The notification should not be sent to alerts that limit their scope to other projects.
Environment:
Additional Details:
Seems like the same handling that was changed in 286e2f2 should be applied to PROJECT_AUDIT_CHANGE notifications.
The text was updated successfully, but these errors were encountered: