Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit PORTFOLIO alert to project does not work for audit changes #975

Closed
dfn-certling opened this issue Mar 19, 2021 · 5 comments · Fixed by #2065
Closed

Limit PORTFOLIO alert to project does not work for audit changes #975

dfn-certling opened this issue Mar 19, 2021 · 5 comments · Fixed by #2065
Labels
defect Something isn't working
Milestone

Comments

@dfn-certling
Copy link

Current Behavior:

This is similar to #616. Limiting PORTFOLIO alerts to projects does not work for PROJECT_AUDIT_CHANGE notifications like suppressing findings and setting their analysis state. Changing a finding status for a project sends the notification via all alerts that include PROJECT_AUDIT_CHANGE not depending on the configured project limits.

Steps to Reproduce:

Define two projects and respective PORTFOLIO alerts limited to the projects with PROJECT_AUDIT_CHANGE selected. Changing a finding status for one of the projects results in a notification sent for both projects.

Expected Behavior:

The notification should not be sent to alerts that limit their scope to other projects.

Environment:

  • Dependency-Track Version: 4.1.0
  • Distribution: Executable WAR
  • Database Server: PostgreSQL
  • Browser: Firefox

Additional Details:

Seems like the same handling that was changed in 286e2f2 should be applied to PROJECT_AUDIT_CHANGE notifications.

@ElisaDgbrt
Copy link

ElisaDgbrt commented Oct 19, 2022

Hello @stevespringett @nscuro
We are facing the same issue (Dependency-Track v4.5.0).
I work in a big company and this problem affects many users and creates a security breach (sensitive information is therefore sent to people outside the projects).
Would it be possible to have a status on this issue ?

@ridaeh
Copy link

ridaeh commented Oct 19, 2022

We have the same issue , we are spammed by other projects alerts

@nscuro
Copy link
Member

nscuro commented Oct 19, 2022

Did not have this on the radar, thanks for bringing it up.

Just raised a PR that should address it. @stevespringett I don't think this justifies a bugfix release, so I'd schedule this for 4.7. Or would you prefer this to be released sooner?

@nscuro nscuro added defect Something isn't working and removed in triage labels Oct 19, 2022
@nscuro nscuro added this to the 4.7 milestone Oct 19, 2022
@stevespringett
Copy link
Member

Thanks all. @nscuro lets target 4.7

nscuro added a commit to nscuro/dependency-track that referenced this issue Oct 20, 2022
to now also include the following subjects:

* `PolicyViolationIdentified`
* `AnalysisDecisionChange`
* `ViolationAnalysisDecisionChange`

Fixes DependencyTrack#975

Signed-off-by: nscuro <[email protected]>
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
stephan-wolf-ais pushed a commit to AISAutomation/dependency-track that referenced this issue Mar 1, 2023
to now also include the following subjects:

* `PolicyViolationIdentified`
* `AnalysisDecisionChange`
* `ViolationAnalysisDecisionChange`

Fixes DependencyTrack#975

Signed-off-by: nscuro <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants