Only dispatch parent metrics update event when metrics of current pro…

…ject actually changed. Signed-off-by: Ralf King <[email protected]>
DependencyTrack · May 6, 2024 · 0cfdd8c · 0cfdd8c
1 parent e0ea31c
commit 0cfdd8c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/main/java/org/dependencytrack/tasks/metrics/ProjectMetricsUpdateTask.java b/src/main/java/org/dependencytrack/tasks/metrics/ProjectMetricsUpdateTask.java
@@ -41,6 +41,7 @@
 import java.util.Map;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.regex.Pattern;
 import java.util.stream.IntStream;
 
@@ -94,8 +95,10 @@ private void updateMetrics(final UUID uuid) throws Exception {
                 case HIGHEST_SEMVER_CHILD -> this.updateHighestSemVerChildCollectionMetrics(project, pm, counters);
             }
 
+            AtomicBoolean metricsChanged = new AtomicBoolean(false);
             qm.runInTransaction(() -> {
                 final ProjectMetrics latestMetrics = qm.getMostRecentProjectMetrics(project);
+                metricsChanged.set(counters.hasChanged(latestMetrics));
                 if (!counters.hasChanged(latestMetrics)) {
                     LOGGER.debug("Metrics of project " + uuid + " did not change");
                     latestMetrics.setLastOccurrence(counters.measuredAt);
@@ -116,7 +119,7 @@ private void updateMetrics(final UUID uuid) throws Exception {
                     DurationFormatUtils.formatDuration(new Date().getTime() - counters.measuredAt.getTime(), "mm:ss:SS"));
 
             Project parent = project.getParent();
-            if(parent != null && parent.getCollectionLogic() != ProjectCollectionLogic.NONE) {
+            if(parent != null && parent.getCollectionLogic() != ProjectCollectionLogic.NONE && metricsChanged.get()) {
                 LOGGER.debug("Scheduling metrics update of project's parent collection " + parent.getUuid());
                 Event.dispatch(new ProjectMetricsUpdateEvent(parent.getUuid()));
             }