Update MMM-ArduPort.js #7
Conversation
|
Thanks for PR @LilCritical, would you mind adding a working screenshot? 🙏 |
MMM-ArduPort.js
Outdated
| if(sensor.name == "LM35") {val.innerHTML = sensor.value + " °C";} | ||
| if(sensor.name == "MQ2") {val.innerHTML = sensor.value + " %";} | ||
| if(sensor.name == "HCSR04") {val.innerHTML = sensor.value + " cm";} |
There was a problem hiding this comment.
You don't need to hard-code the formats here. We have format options, see here: https://github.com/Dentrax/MMM-ArduPort#configuration-options
There was a problem hiding this comment.
hardcoding this is what fixed this issue since
formatValue: function(value, sensor) {
is not working properly ( value remains undefined )
There was a problem hiding this comment.
Oh, got it. Instead of applying a workaround, have you enough free time to find the root cause and apply the fix in the correct place? I would be very grateful if you could give a hand for this. 🙏
There was a problem hiding this comment.
Oh, got it. Instead of applying a workaround, have you enough free time to find the root cause and apply the fix in the correct place? I would be very grateful if you could give a hand for this. 🙏
i will try to fix , but i need todo more research , fairly new to this type of coding.
but i am familiar with python and js , but more in bot developing
MMM-ArduPort.js
Outdated
|
|
||
| description.innerHTML = sensor.description; | ||
| row.appendChild(description); | ||
| var description = document.createElement("div"); |
Hello , Thanks for your review i will look into it after work ✌️ |
fix without hardcoding
fix without hardcoding sensors
Fix for not showing data on mirror