Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fc namescheck #115

Merged
merged 29 commits into from
Nov 10, 2023
Merged

Fc namescheck #115

merged 29 commits into from
Nov 10, 2023

Conversation

bio-la
Copy link
Collaborator

@bio-la bio-la commented Sep 29, 2023

checked all the ADT/ GEX nomenclature and fixed some misspelled params

@bio-la bio-la requested a review from crichgriffin September 29, 2023 10:37
Copy link
Contributor

@crichgriffin crichgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine to me, But can you update the CHANGELOG.md. Put it under the fixed section.

@bio-la
Copy link
Collaborator Author

bio-la commented Oct 18, 2023

gotcha, now specified under "fixed".
let's review together before merging cause it's a big change. (maybe stash for next release?)

@crichgriffin crichgriffin merged commit e4ca7b3 into main Nov 10, 2023
@bio-la bio-la deleted the fc_namescheck branch February 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants