Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid hardcoded _FillValue and replacing fillvalue in cast #114

Merged
merged 14 commits into from
Jul 7, 2023
Merged

avoid hardcoded _FillValue and replacing fillvalue in cast #114

merged 14 commits into from
Jul 7, 2023

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Jul 7, 2023 •
edited
Loading

fixes #113 (with a minimal change approach). This issue was introduced by fixing #101

@JoerivanEngelen JoerivanEngelen mentioned this pull request Jul 7, 2023
Open
visr
visr reviewed Jul 7, 2023
View reviewed changes
JoerivanEngelen
JoerivanEngelen reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see a few undefined imports in the tests which are easy to fix and then this is good to go!

@JoerivanEngelen JoerivanEngelen merged commit 59a6ce6 into Deltares:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr left review comments

@JoerivanEngelen JoerivanEngelen JoerivanEngelen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

solve edge_node_connectivity in xugrid 0.6.0
3 participants
@veenstrajelmer @visr @JoerivanEngelen