xugrid.open_dataset results in a locked netCDF file

[Huite]

Current implementation does this:

def open_dataset(*args, **kwargs):
    ds = xr.open_dataset(*args, **kwargs)
    return UgridDataset(ds) 

Internally, the UgridDataset constructor creates a new dataset, and so the ds reference is lost, making UgridDataset.close() a dud.

We should likely do something like:

class UgridDataset:
    def __init__(self, dataset):
        self._original = dataset
        # ... rest of initialization
    
    def close(self):
        self._original.close()

It might be possible that dataset is None, though.

Explicit indexes would also solve this, since we'd just use/return an ordinary xarray dataset.

[Huite]

Funnily enough, I apparently looked into this in the past, and used xarray's set_close, which does exactly the right thing: it associates the close of a (new) object with another. It was part of the open_dataarray code, but not of the UgridDataset and UgridDataArray constructors. Using it consistently does the trick (and doesn't require a new close method).