-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting Thaven from Impstation #2948
base: master
Are you sure you want to change the base?
Conversation
RSI Diff Bot; head commit 304d809 merging into c176638 Resources/Textures/_Impstation/Mobs/Customization/markingsbundle1.rsi
Resources/Textures/_Impstation/Mobs/Customization/thaven/thaven.rsi
Resources/Textures/_Impstation/Mobs/Customization/thaven/thaven_hair.rsi
Resources/Textures/_Impstation/Mobs/Species/Thaven/displacement.rsi
|
dont look yet |
i'm looking |
ok THANK YOU AIR FRYER |
… added missing species yml, added missing marking bundle from Impstation.
af896f6
to
38f118f
Compare
could not have worked on this w/o the help of airfryer, sowelipililimute, and toby, tysm yall i hope it works now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direction review fully in progress now, I estimate we will have an answer in 24 hours. That being said, if this is decided to be merged I will be asking that we not merge this for a few extra days; I wanna let the IPC adjustments shake out a bit.
all good, not in any rush!!! good luck to this PR, hoping it gets approved 🫡 |
thavenbignaturals peak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work you and the Impstation gamers have put in here! I am super excited to approve this, and look forward to seeing these spelfs around.
The bad news; we'd like to put a delay of 2~ days for all the IPC changes to settle down before this is merged. Thaven on the weekend!
About the PR
Porting the Thaven species from Impstation
Why / Balance
IMPORTANT NOTE: Currently (2/9) this PR has Thaven moods set to their default Impstation settings. Moods will need to be heavily adjusted - both their mood pools, as well as what affects their moods. Feedback on mood pools is required from direction. There has been discussion about making Thaven moods change with high glimmer levels, direction feedback will be needed for this as well!
feedback for moods here
feedback for holidays for holiday specific moods here
general feedback thread for Thaven
Technical details
Many code changes, primarily adding files related to Thaven, including Mood systems, new markings, etc. Primary sources are impstation/imp-station-14#1302 and impstation/imp-station-14#1272
Media
Requirements
Breaking changes
Changelog
🆑