course project #28
Open
course project #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collide with other physics objects
…file to their own
… server. session waits 2 connection to start after 3 sec.
bohdanpc
reviewed
Oct 8, 2023
battle_tanks/client/battle_tanks.cpp
Outdated
| #include "game/game_objects/forest_map_game_object.hpp" | ||
| #include "game/game_objects/game_object_frame_restorer_packet.hpp" | ||
|
|
||
| enum class player_game_state : unsigned int |
There was a problem hiding this comment.
That specifically states about the network state, should be depicted in its name as well.
battle_tanks/client/battle_tanks.cpp
Outdated
| window->close(); | ||
| } | ||
|
|
||
| if (player_state == player_game_state::main_lobby) |
There was a problem hiding this comment.
I believe it's better to move state's handling into its own function/classes
battle_tanks/client/battle_tanks.cpp
Outdated
|
|
||
| void set_text_color(sf::Text& text, const sf::Int32 current_hp) | ||
| { | ||
| if (current_hp > 50) |
There was a problem hiding this comment.
it's better to have all settings like this one in one or more dedicated config files for easier track of all constants and fast configuration of the game flow from one place. Possibly moving it all into some sort of db later to configure them outside of the code
|
|
||
| namespace bt | ||
| { | ||
| typedef std::uint32_t uuid; |
DeliriumInTheVoid
force-pushed
the
feature/battle_tanks
branch
from
7a45b67 to
f9c7a5e
Compare
DeliriumInTheVoid
force-pushed
the
feature/battle_tanks
branch
from
f9c7a5e to
b43cbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how to run
controls
game play
shot to your opponent until one's HP less or equal "0", you will take damage from all collisions. so you can ram you enemy if you have more HP, be careful with rock and edges, you will take damage from it either.
network
if you want to play on two PCs. You should rebuild clients and change ip for connection to the server ip where you are going to run it. Same with port, but server can be run with port configuration ./battle_tanks_server.exe -port xxxx
client line to change:
game play
battle tanks game play.webm
PS
unfortunately a lot of hardcode there and not all code refactored and split to the layers and appropriate classes, strong connectivity and communication between some parts of the code and no UI at all. But still it's playable.