Drop support for 32bit windows with MSVC. #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 83 83
Lines 12237 12237
=======================================
Hits 8360 8360
Misses 3877 3877 ☔ View full report in Codecov by Sentry. |
DelSkayn
force-pushed
the
fix-unsafe-precoditions
branch
2 times, most recently
from
0b46ca9 to
06db4d1
Compare
DelSkayn
changed the title
DelSkayn
force-pushed
the
fix-unsafe-precoditions
branch
from
06db4d1 to
115462c
Compare
DelSkayn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out alignment on i686 MSVC is basically broken right now as MSVC is inconsistent.
A 64bit integer on i686 can have a 4 byte alignment when clang and rust assume it is 8. This causes slice::from_raw_parts to panic since it will see 4 byte aligned values originating from the stack as misaligned.
For more info see rust-lang/rust#112480.
This makes is basically impossible to correctly call QuickJS functions on that platform. Any pointer returned from QuickJS might be misaligned according Clang. Working around this would be a lot of work for a quite old platform which could still be supported with a different toolchain. So I opted to drop support for i686 MSVC.