Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPScan - implement confidence #5810

Merged
merged 5 commits into from
Jan 28, 2022
Merged

WPScan - implement confidence #5810

merged 5 commits into from
Jan 28, 2022

Conversation

damiencarol
Copy link
Contributor

@damiencarol damiencarol commented Jan 23, 2022 •
edited
Loading

Work done

  • Implement scanner confidence for WPScan and fix a bug in models.py when confidence is max
  • Implement date for findings
  • Add more real data to test for unit tests (empty file and real site scan from Error 500 on import of wpscan results v2 API #5774 obfuscated)

image

@damiencarol damiencarol requested review from devGregA, StefanFl and a team January 23, 2022 13:02
StefanFl
StefanFl suggested changes Jan 24, 2022
View reviewed changes
@damiencarol
Copy link
Contributor Author

made some changes for @StefanFl feedback

@StefanFl
Copy link
Contributor

One of my 2 change requests makes a problem :-(

@StefanFl
Copy link
Contributor

One of my 2 change requests makes a problem :-(

Not so sure about it anymore, see my comments for the test cases.

StefanFl
StefanFl suggested changes Jan 27, 2022
View reviewed changes
@StefanFl StefanFl added this to the 2.7.0 milestone Jan 27, 2022
@StefanFl StefanFl merged commit 616d221 into DefectDojo:dev Jan 28, 2022
@damiencarol damiencarol deleted the issue5774 branch January 28, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanFl StefanFl StefanFl approved these changes

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@devGregA devGregA Awaiting requested review from devGregA

Assignees
No one assigned
Labels
parser unittests
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@damiencarol @StefanFl @valentijnscholten