Porting memory leak fixes from mainline repo #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
|
Task linked: CU-86epcv4zv [bugfix] fix "dpxSoilGUI" memory leak |
mderbaso-deepx
commented
Jun 5, 2024
| @@ -39,23 +35,22 @@ RUN apt-get -qq update && \ | |||
| wget http://packages.osrfoundation.org/gazebo.key -O - | apt-key add - && \ | |||
| add-apt-repository ppa:kisak/kisak-mesa && \ | |||
| curl -sSL http://get.gazebosim.org | sh && \ | |||
| update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 800 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10 && \ | |||
There was a problem hiding this comment.
we already have 11th version of compiler in image
There was a problem hiding this comment.
hm... it's not linking with g++10/11, it asks -fPIC, strange... Should investigate it, but later
There was a problem hiding this comment.
about linking: gazebosim#950
mderbaso-deepx
force-pushed
the
fixing/CU-86epcv4zv
branch
2 times, most recently
from
8b7930b to
376da91
Compare
mderbaso-deepx
force-pushed
the
fixing/CU-86epcv4zv
branch
from
376da91 to
5f157c4
Compare
This was broken by gazebosim/gz-cmake#399, since we dropped the gazebo-specific flag, we can use native CMake mechanism for marking this library position-independent. Signed-off-by: Michael Carroll <[email protected]>
|
Maybe enable merge w/o squash for this repo? |
dmo-deepx
reviewed
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Porting commits related to resource deallocation from mainline
Motivation and Context
How Has This Been Tested?
ran empty simulation and one project-specific simulation
---