Pins numpy<2
, fix svd for scipy>=1.11.0
#2827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request pins the numpy version required for DeepLabCut to
numpy<2.0.0
and fixes SVD computation inTracklet.estimate_rank
forscipy>=1.11.0
.scipy SVD computation
With
scipy<1.11.0
, computation of the SVD of an all-zero matrix would be successful, returning an all-zero array for the singular values. Withscipy>=1.11.0
, this fails with aValueError
. Hence, we first check if the matrice is the zero matrix before computing the SVD. If it is, we return a zero-vector to match the behavior ofscipy<1.11.0
.This can be verified with the following script:
With
scipy==1.10.1
this succeeds with the output:While with
scipy==1.15.0
this fails with the output: