Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions #1

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Add GitHub Actions #1

merged 4 commits into from
Feb 22, 2024

Conversation

knutkirkhorn
Copy link
Contributor

  • I only added Prettier in the actions since that was what you had installed in the repo and I'm not sure of your preferences in linter and linter rules.
  • I set it up to run against both Node.js 18 and 20, if you only want to test against latest I can change that.
  • Also I just used npm instead of bun there, not sure if that is ok?

@chribjel
Copy link
Member

chribjel commented Feb 22, 2024 •
edited
Loading

Is it hassle to set it up with bun like this?
https://bun.sh/guides/runtime/cicd

EDIT: Maybe a build-step would be nice as well?

@knutkirkhorn
Copy link
Contributor Author

Probably not, I'll try it out!

Agree on the build step as well 👍

chribjel
chribjel approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@chribjel chribjel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VincentPriceLooksGoodToMeGIF

@chribjel chribjel merged commit e6b80da into Decidable-AS:main Feb 22, 2024
@knutkirkhorn knutkirkhorn deleted the github-actions branch February 22, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chribjel chribjel chribjel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knutkirkhorn @chribjel