-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 747 add full pipeline with preprocessing #807
Feature/sg 747 add full pipeline with preprocessing #807
Conversation
…dd_full_pipeline_with_preprocessing
src/super_gradients/training/models/detection_models/yolo_base.py
Outdated
Show resolved
Hide resolved
src/super_gradients/training/models/detection_models/yolo_base.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing down the main concern we have discussed together:
- Hard coding the default _image_processor and _class_names is bad practice, and might lead users who do not use these (which will probably happen - any time they do not train on coco). Lets add setters that will by the pretrained_weights str set these attributes accordingly.
- Please also add a ticket for making it possible to set them from the recipe itself - so that when users complete their training they can use predict right away.
Dont forget to add the implementation for DeciYolo.
@shaydeci I also updated the super-gradients/src/super_gradients/training/models/results.py Lines 1 to 143 in 8e837a8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* wip * move to imageprocessors * wip * add back changes * making it work fully for yolox and almost for ppyoloe * minor change * working for det * cleaning * clean * undo * replace empty with none * add _get_shift_params * minor doc change * cleaning wip * working for multiple images * add ppyoloe * replace pydantic with dataclasses and fix typing * add docstrings * doc improvment and use get_shift_params in transforms * add tests * improve comment * rename * wip * add option to keep ratio in rescale * make functions private * remove DetectionPaddedRescale * fix doc * big commit with wrong things * try undo bad change * doc * minor doc * add a lot of doc * fix comment * minor change * add __init__.py to pipelines * replace size with shape * wip * make pipeline work again with Predction objects * set processing params based on checkpoints * remove unwanted change * use __call__ instead of _run --------- Co-authored-by: Shay Aharon <[email protected]>
Includes code from #804, so #804 needs to be merged first