Feature/sg 1147 notebooks in repo #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BloodAxe
requested review from
shaydeci,
ofrimasad and
Louis-Dupont
as code owners
Louis-Dupont
reviewed
Oct 3, 2023
shaydeci
suggested changes
Oct 3, 2023
…rrect SG version installed and bumped up SG version in master to reflect that we already have 3.2.1
…o' into feature/SG-1147-notebooks-in-repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce CI job & workflow to run notebooks during integration tests.
CI Config now contains
run_and_convert_notebooks_to_docsparameter to trigger a workflow manually and it will be executed as part of sanity test & release.To add new notebooks to be tested, add new notebooks in
Makefiletargetrun_and_convert_notebooks_to_docsHere is an example of the failing job (Added intentionally outdated notebook) - https://app.circleci.com/pipelines/github/Deci-AI/super-gradients/9479/workflows/6499349e-27f7-47a1-a2eb-ce40578905c2/jobs/28496