Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix classnames #210

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix classnames #210

merged 3 commits into from
Nov 14, 2023

Conversation

Louis-Dupont
Copy link
Contributor

2 cases seem to not be properly handled

  1. Clear mistake in the code where the class_names mapping is reversed in a specific case
  2. Loading from cache of class_names when it is a dict loads the ids as str instead of int

BloodAxe
BloodAxe previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment (Feel free to ignore if we know for sure the class names is always a dict and not DictConfig)

BloodAxe
BloodAxe approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit e2f70ca into master Nov 14, 2023
@BloodAxe BloodAxe deleted the hotfix/SG-00-fix_class_name branch November 14, 2023 10:45
@Louis-Dupont Louis-Dupont restored the hotfix/SG-00-fix_class_name branch November 21, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis-Dupont @BloodAxe