-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sg 912 duplicates #136
Conversation
…feature/SG-912_duplicates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments inline.
Can you also run this script https://github.com/Deci-AI/data-gradients/blob/master/scripts/describe_features.py
?
This will automatically update the documentation page for the features.
Do we want to add it as a deafult feature in our configs ?
This would result in always asking the user for the train and validation directory (currently, as we cant automatically derive them).
That's a good question... Forcing the user to input the path of train/val would not be a nice experience. So I guess maybe we should just not add it by default. But if we don't add it in the default feature extractors we should somehow indicate the user that this feature is available. Not sure what's the right way
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. just minor comments
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
src/data_gradients/feature_extractors/common/image_duplicates.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. great work
Finally, in PR.
Do we want to add it as a deafult feature in our configs ?
This would result in always asking the user for the train and validation directory (currently, as we cant automatically derrive them).