Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 890 add filter option for multiclass #129

Merged
merged 26 commits into from
Jul 10, 2023
Merged

Feature/sg 890 add filter option for multiclass #129

merged 26 commits into from
Jul 10, 2023

Conversation

Louis-Dupont
Copy link
Contributor

Example to show the difference between train/val

image

@BloodAxe
Copy link
Contributor

BloodAxe commented Jul 5, 2023

Maybe let's use term "Support" instead of "Frequency", because it's a bit (to me) misleading.

@BloodAxe
Copy link
Contributor

BloodAxe commented Jul 5, 2023

Second - We have inconsistent names on Y axis. It's "Class" on the first plot and "Class Names" in the second.
Pro tip: Let's have some StringConstants class with pre-defined string literals for axis names and use them instead of hard-coding same names everywhere?

@Louis-Dupont
Copy link
Contributor Author

Louis-Dupont commented Jul 5, 2023 •
edited
Loading

Second - We have inconsistent names on Y axis. It's "Class" on the first plot and "Class Names" in the second. Pro tip: Let's have some StringConstants class with pre-defined string literals for axis names and use them instead of hard-coding same names everywhere?

Good catch, I created a ticket to add these literals in the plot_options

ofrimasad
ofrimasad reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments inline

ofrimasad
ofrimasad previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side.
@BloodAxe can we merge?

@BloodAxe
Copy link
Contributor

BloodAxe commented Jul 7, 2023

To me there is still a few minor issues to address remaining. See inline comments

BloodAxe
BloodAxe approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit d5de9dc into master Jul 10, 2023
@ofrimasad ofrimasad deleted the feature/SG-890-add_simplt_multicall_filter_option branch July 10, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@ofrimasad ofrimasad ofrimasad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Louis-Dupont @BloodAxe @ofrimasad