Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastCardChange #95

Closed
patrickwieth opened this issue Oct 19, 2022 · 3 comments · Fixed by #107
Closed

lastCardChange #95

patrickwieth opened this issue Oct 19, 2022 · 3 comments · Fixed by #107
Assignees

Comments

@patrickwieth
Copy link
Member

we should save a variable that stores when the content of a card was changed

so whenever a card gets banned or saveCardContent changes the content, this variable should be set to the current block height

this allows the gameclient to see if it has the most recent card set, or has to update stuff

the variable should be accessible via q-cardchain-info

@lxgr-linux
Copy link
Member

Why would this be relevant to access via q-cardchain-info?
How I understood it, this variable would be a attribute of the Card type and therefore different for every card. Did you maybe mean q_card?

@patrickwieth
Copy link
Member Author

No, this is global. Without it the gameclient must poll all card content every 10s and see if there are changes, with this feature only 1 query must be done and when a card has changed, the new cards can be queried.
So we already have a image hash on q_card_content but we don't know if any card has changed...

@lxgr-linux lxgr-linux self-assigned this Dec 17, 2022
@lxgr-linux
Copy link
Member

lxgr-linux commented Dec 17, 2022

Cases for setting this:

  • Card suspended
  • Card banned
  • Card nerfed/buffed
  • Make card playable (council)

More @patrickwieth @nlsui ?

lxgr-linux added a commit that referenced this issue Dec 17, 2022
@lxgr-linux lxgr-linux linked a pull request Dec 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants