-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apps/whale-api): api error when getting all data using OCG listing endpoint but response is empty #2016
Conversation
Code Climate has analyzed commit 76a8f6d and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 87.90% // Head: 93.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
+ Coverage 87.90% 93.56% +5.65%
==========================================
Files 364 366 +2
Lines 10975 10990 +15
Branches 1433 1433
==========================================
+ Hits 9648 10283 +635
+ Misses 1275 682 -593
+ Partials 52 25 -27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Docker build preview for jellyfish/apps is ready! Built with commit f42fd8c
You can also get an immutable image with the commit hash
|
To keep the behaviour of nextProvider as before
What this PR does / why we need it:
to allowto enforce data and limit to benextProvider
ofApiPagedResponse.of
to be able to returnundefined
> 0
inApiPagedResponse.of
listProposals()
andlistProposalVotes()
but response is empty. This is because on the upstream (ain
) is usingsize: 0
to return all results.Which issue(s) does this PR fixes?:
Fixes #
Additional comments?: