Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-transaction): add mint token in dftx and txn builder #2004

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

pierregee
Copy link
Contributor

@pierregee pierregee commented Jan 25, 2023

What this PR does / why we need it:

  • Add dftx for minting token
  • Add txn builder for minting token
  • Add e2e tests

Which issue(s) does this PR fixes?:

Fixes #1823

Additional comments?:

  • One concern that requires more deep diving in the code is this - to is not optional in this PR but it is in ain. Need to deep dive on how to do it properly with composer. This parameter (to) being required still caters for the need of Bridge API.

Relevant Issue on bridge: BirthdayResearch/quantum#185

@github-actions github-actions bot added area/packages kind/feature New feature request labels Jan 25, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 25, 2023

Code Climate has analyzed commit 32f08a8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 32f08a8
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63d225954f36000009c1787c
😎 Deploy Preview https://deploy-preview-2004--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 93.50% // Head: 91.64% // Decreases project coverage by -1.86% ⚠️

Coverage data is based on head (32f08a8) compared to base (23b5c04).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
- Coverage   93.50%   91.64%   -1.86%     
==========================================
  Files         366      366              
  Lines       10987    10990       +3     
  Branches     1433     1433              
==========================================
- Hits        10273    10072     -201     
- Misses        684      874     +190     
- Partials       30       44      +14     
Impacted Files Coverage Δ
...h-transaction-builder/src/txn/txn_builder_token.ts 71.42% <0.00%> (-28.58%) ⬇️
...ellyfish-transaction/src/script/dftx/dftx_token.ts 91.37% <100.00%> (-8.63%) ⬇️
packages/whale-api-client/src/api/oracles.ts 22.22% <0.00%> (-77.78%) ⬇️
packages/playground/src/bots/BlockGenerateBot.ts 33.33% <0.00%> (-66.67%) ⬇️
...es/ocean-api-client/src/errors/TimeoutException.ts 33.33% <0.00%> (-66.67%) ⬇️
packages/whale-api-client/src/api/poolpairs.ts 46.15% <0.00%> (-53.85%) ⬇️
packages/jellyfish-address/src/p2wsh.ts 48.27% <0.00%> (-51.73%) ⬇️
...kages/playground-api-client/src/apis/Playground.ts 50.00% <0.00%> (-50.00%) ⬇️
apps/whale-api/src/module.api/oracle.controller.ts 44.00% <0.00%> (-44.00%) ⬇️
packages/playground/src/Playground.ts 62.50% <0.00%> (-37.50%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 25, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit d616a8b

  • ghcr.io/jellyfishsdk/legacy-api:pr-2004
  • ghcr.io/jellyfishsdk/playground-api:pr-2004
  • ghcr.io/jellyfishsdk/status-api:pr-2004
  • ghcr.io/jellyfishsdk/whale-api:pr-2004

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:d616a8ba42c58ee43decb8f45c5bd3946d12c39b
  • ghcr.io/jellyfishsdk/playground-api:d616a8ba42c58ee43decb8f45c5bd3946d12c39b
  • ghcr.io/jellyfishsdk/status-api:d616a8ba42c58ee43decb8f45c5bd3946d12c39b
  • ghcr.io/jellyfishsdk/whale-api:d616a8ba42c58ee43decb8f45c5bd3946d12c39b

@thedoublejay thedoublejay marked this pull request as ready for review January 26, 2023 07:58
@fuxingloh fuxingloh merged commit 021056e into main Jan 31, 2023
@fuxingloh fuxingloh deleted the pierregee/mint-token-dftx-txn-builder branch January 31, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consortium DfTxs (Custom Light Transaction)
3 participants