-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-transaction): add mint token in dftx and txn builder #2004
Conversation
Code Climate has analyzed commit 32f08a8 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 93.50% // Head: 91.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
==========================================
- Coverage 93.50% 91.64% -1.86%
==========================================
Files 366 366
Lines 10987 10990 +3
Branches 1433 1433
==========================================
- Hits 10273 10072 -201
- Misses 684 874 +190
- Partials 30 44 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Docker build preview for jellyfish/apps is ready! Built with commit d616a8b
You can also get an immutable image with the commit hash
|
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #1823
Additional comments?:
to
is not optional in this PR but it is inain
. Need to deep dive on how to do it properly with composer. This parameter (to
) being required still caters for the need of Bridge API.Relevant Issue on bridge: BirthdayResearch/quantum#185