Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pass BUILD_VERSION into docker builds #2716

Closed
wants to merge 1 commit into from

Conversation

sieniven
Copy link
Contributor

Summary

  • Pass BUILD_VERSION into docker build as build arg to set defi client version with tag correctly

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven requested a review from prasannavl November 23, 2023 11:07
@sieniven
Copy link
Contributor Author

Closing this PR. Resolving the dirty flag on docker build is non-trivial on the CI because passing along the BUILD_VERSION will not work as release builds will define BUILD_DESC directly, while dev builds will define BUILD_SUFFIX. The correct way to resolve the CI builds is to shift the build entirely out of the docker builds, which is the desired plan anyway.

@sieniven sieniven closed this Nov 23, 2023
@sieniven sieniven deleted the niven/ci-docker-fix branch November 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant