Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Clean up backend vicinity #2641

Merged
merged 3 commits into from
Oct 31, 2023
Merged

EVM: Clean up backend vicinity #2641

merged 3 commits into from
Oct 31, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Oct 31, 2023 •
edited
Loading

Summary

  • Clean up RPCs when creating backend instances
  • Resolves evm: debug_traceTransaction #2634
  • Backend instance should propagate error if block query fails instead of returning a default
  • Passing full block state into backend vicinity to ensure EVM state execution is correct
  • Rename to eth_debug_rpc for ffi cpp exports

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven mentioned this pull request Oct 31, 2023
Merged
@prasannavl prasannavl merged commit bc79d30 into master Oct 31, 2023
15 of 18 checks passed
@prasannavl prasannavl deleted the evm/fix-vicinity branch October 31, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

@shohamc1 shohamc1 shohamc1 approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees
No one assigned
Labels
ci/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sieniven @shohamc1 @Jouzo @prasannavl