Add disable jscs option to qunit #63
Conversation
|
I was thinking that this would use an exclude matcher when disabled. Since we already match the default case for inclusion, we only need to suppress when the nojscs flag is set. I would also like to require those changes to the test loader (I'll get 'em merged and tagged tomorrow), so we don't need to maintain both paths forever. It seems reasonable to me, that if an app wants this new feature that they have to ensure they are using the most recent version of the test loader... |
|
Yeah, that makes sense. I'll go ahead and make it an exclusion matcher, and simplify the code to assume your update is in. |
|
ok, updated. will check it out against your changes tomorrow. |
|
|
||
| included: function(app, parentAddon) { | ||
| var target = (parentAddon || app); | ||
| this._super.included(target); |
There was a problem hiding this comment.
I think this needs to call
this._super.included.apply(this, arguments);
(the super.included call needs to be bound to this)
Also, do we need the massaging of arguments to determine target like this or can we just call super with the args we were called with?
There was a problem hiding this comment.
So I just took que from ember-cli-qunit: https://github.com/ember-cli/ember-cli-qunit/blob/master/index.js#L38 but if that's not needed, I'd be happy to just call super. I can try it out and see.
|
Thanks! Just need a squash, por favor :). |
Simplify code based on review comments check for qunit, call fix super invoke on included Remove trailing line breaks
|
squashed! 👞 |
Add disable jscs option to qunit
|
@toddjordan Thank you! I'll release in a little bit. |
Fix for Issue https://github.com/dockyard/ember-suave/issues/62
I added a checkbox to qunit -> "Disable JSCS"
When checked, none of the Suave JSCS tests are run.
I added 2 cases for disabling: