Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155.
The
steam
library for Python was updated yesterday to address an issue with theparse_appinfo
function. The format of this changed on Steam's side and so the library had to be updated to accommodate this following commit ValvePython/steam@abf65ab.Honestly I don't really understand what the changes here did but I can confirm it fixes the issue for me when running from source. Also from my armchair glance at the commit this should not have any breakages on Flatpak or require any sort of Python version bump. It is a fix but it doesn't seem to do anything too "magical" or extravegant that might break compatibility anywhere. My concern here is bumping from a minimum of
1.1.0
to a minimum of1.4.4
. In testing from source I could not see anything that has broken (yet, anyway) but I'm also not sure what the previous version of the library I was using was. I would guess that this is probably fine but the changes from 1.1.0 to 1.4.4 may want to be reviewed with more scrutiny first.Currently the
requirements.txt
mandatesteam>=1.1.0
, however since this new version of thesteam
library fixes a critical bug, I set the version as>=1.4.4
, forcing this newer version since without it, various pieces of functionality will not work without this version or higher.Opening this as a PR for transparency on the research process for this fix, as well as discussion. Merging a 3 character change on its own is rarely worth a PR but the commentary around the change might be worth it :-)
Thanks!