Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is a Golden SQL query passed to the tool but not used? #196

Closed
lpxiangyan9 opened this issue Oct 7, 2023 · 1 comment
Closed

Why is a Golden SQL query passed to the tool but not used? #196

lpxiangyan9 opened this issue Oct 7, 2023 · 1 comment

Comments

@lpxiangyan9
Copy link

for example:
in dataherald_sqlagent.py method get tools() every tool set context but not used

@MohammadrezaPourreza
Copy link
Contributor

Thank you, @lpxiangyan9, for bringing this to our attention.
The utilization of few-shot examples in Dataherald_SQLAgent differs from other SQL generators (others use a predefined fix number of examples but Dataherald_SQLAgent has a dynamic number of few-shot samples). Consequently, we had to retrieve the few-shot samples within the agent, despite having initially passed them to the agent. We have to consider remove passing the context to the tools for better efficiency. I would appreciate your suggestion on this matter if you have other solutions. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants