-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column reordering breaks types used for sorting #90
Comments
AllanJard
added a commit
to DataTables/DataTablesSrc
that referenced
this issue
Jan 16, 2025
…solved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90
AllanJard
pushed a commit
to DataTables/Dist-DataTables
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
Hi - many thanks for this and apologies for the delayed reply. I actually think the issue goes a little deeper and DataTables should resolve the data types for the columns on ordering if needed. I've committed that fix here. |
AllanJard
pushed a commit
to DataTables/Dist-DataTables-DataTables
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-Bootstrap
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-Foundation
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-jQueryUI
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-SemanticUI
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-Bootstrap4
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-Bootstrap5
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
AllanJard
pushed a commit
to DataTables/Dist-DataTables-Bulma
that referenced
this issue
Jan 16, 2025
…s null when it is sorted, it should be resolved. This could happen after data has been invalidated (e.g. after column reordering). DataTables/ColReorder#90 Sync to source repo @7bceadf844166e18631bbf022babaf83887d6956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is with a recently downloaded:
After column reordering, all columns sort like string (the default) even though they were initialized with, e.g., "num". Before reordering, all sorting works as expected.
It took me a while to find this, but in the function:
The call to rows().invalidate() also invalidates columns, including their types (sType becomes null). To rectify the behavior in my case, I inserted an extra call to columns.types().
The text was updated successfully, but these errors were encountered: