[Feature][admin] Task submit approval #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
approval table query
todo: 1.handle reload 2.task info query 3.properties roll back 4.code optimization 5.h2 and pg sql 6.function test
todo: 1.task info query 2.properties roll back 3.code optimization 4.h2 and pg sql 5.function test
todo: 1.properties roll back 2.layout 3.code optimization 4.h2 and pg sql 5.function test
todo: 1.layout 2.code optimization 3.h2 and pg sql 4.function test
todo: 1.code optimization 2.h2 and pg sql 3.function test
todo: 1.code optimization 2.h2 and pg sql 3.function test
todo: 1.code optimization 2.h2 and pg sql 3.function test
|
The menu list data needs to be added to the upgrade file of the corresponding db type |
|
如果平台内只有一个用户时,开启强制交叉审核时,在审批人列表中无法选择审批人 |
|
@Zzm0809 感谢指正，我将于本周内向此分支提交新的commit来修复上述问题 |
support tenant
todo: full test for current feature
Zzm0809
approved these changes
Jan 9, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
#4061
Brief change log
Verify this pull request
In configuration center, here is an option to enable task submit approval, when it is enabled:
Task cannot be submitted if there's no approved approval for current task version
User can submit an approval by this button, before an approval is created, task will be published first
A reviewer is needed, also, user can leave some comments like 'Please take a look'
Approval can be managed in auth center, an approval can be submitted, withdrawn, canceled, approved or rejected.
The task info can also be checked
After the approval of current task version is approved, task can be submitted
When task submit approval is disabled,
Approval create and submit button will not be shown
Approval management page is not available neither
Task can be submitted directly