Skip to content

Commit

Permalink
[Feature][Web]Replace NPM, switch to PNPM (#4157)
Browse files Browse the repository at this point in the history
  • Loading branch information
zackyoungh authored Jan 21, 2025
1 parent 273007c commit 631a386
Show file tree
Hide file tree
Showing 10 changed files with 65 additions and 36,200 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- uses: actions/setup-node@v3
if: steps.filter.outputs.frontend == 'true'
with:
node-version: 16
node-version: 18
- name: Get npm cache directory
id: npm-cache-dir
if: steps.filter.outputs.frontend == 'true'
Expand All @@ -79,10 +79,10 @@ jobs:
${{ runner.os }}-node-
- name: Install Dependencies
if: steps.filter.outputs.frontend == 'true'
run: cd dinky-web && npm install --no-audit --progress=false --legacy-peer-deps
run: cd dinky-web && npm install -g pnpm && pnpm install
- name: Npm Web Build
if: steps.filter.outputs.frontend == 'true'
run: cd dinky-web && npm run build
run: cd dinky-web && pnpm run build
- name: Upload artifact
uses: actions/upload-artifact@v4
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docker_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- 'dinky-web/**'
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Get npm cache directory
id: npm-cache-dir
run: |
Expand All @@ -53,9 +53,9 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Install Dependencies
run: cd dinky-web && npm install --no-audit --progress=false --legacy-peer-deps
run: cd dinky-web && npm install -g pnpm && pnpm install
- name: Npm Web Build
run: cd dinky-web && npm run build
run: cd dinky-web && pnpm run build
- name: Upload artifact
uses: actions/upload-artifact@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/format_code.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
frontend:
- 'dinky-web/**'
backend:
- '!dinky-web/**'
- '!dinky-web/**'
- name: Run spotless apply
if: steps.filter.outputs.backend == 'true'
Expand All @@ -69,7 +69,7 @@ jobs:
${{ runner.os }}-node-
- name: Install Dependencies
if: steps.filter.outputs.frontend == 'true'
run: cd dinky-web && npm install --only=dev --prefer-offline --no-audit --progress=false --legacy-peer-deps
run: cd dinky-web && npm install -g pnpm && pnpm install --only=dev --prefer-offline
- name: Run frontend format
if: steps.filter.outputs.frontend == 'true'
run: cd dinky-web && npm run lint:prettier
Expand Down
Loading

0 comments on commit 631a386

Please sign in to comment.