Skip to content

Commit

Permalink
fix(ui): handle null data in overview and test suites pages
Browse files Browse the repository at this point in the history
  • Loading branch information
@aarthy-dk
aarthy-dk committed Sep 18, 2024
1 parent b9900c9 commit e885361
Show file tree
Hide file tree
Showing 2 changed files with 95 additions and 84 deletions.
123 changes: 66 additions & 57 deletions testgen/ui/views/overview.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from testgen.ui.navigation.page import Page
from testgen.ui.services import test_suite_service
from testgen.ui.session import session
from testgen.utils import to_int

STALE_PROFILE_DAYS = 30

Expand All @@ -29,8 +30,8 @@ def render(self, project_code: str | None = None, **_kwargs):
testgen.page_header(
"Project Overview",
"https://docs.datakitchen.io/article/dataops-testgen-help/introduction-to-dataops-testgen",
)
)

render_project_summary(table_groups_df)

st.html(f'<h5 style="margin-top: 16px;">Table Groups ({len(table_groups_df.index)})</h5>')
Expand All @@ -54,13 +55,13 @@ def render_project_summary(table_groups: pd.DataFrame) -> None:
# delta=project_score_delta or 0,
# label_visibility="collapsed",
# )

with summary_column:
st.caption("Project Summary")
st.html(f"""<b>{len(table_groups.index)}</b> table groups
<br><b>{int(table_groups['latest_tests_suite_ct'].sum())}</b> test suites
<br><b>{int(table_groups['latest_tests_ct'].sum())}</b> test definitions
""")
""")


@st.fragment
Expand All @@ -72,7 +73,7 @@ def render_table_group_card(table_group: pd.Series, project_code: str, key: int)
# Without this CSS, the "hidden" elements in the expanded state take up space
testgen.no_flex_gap()

with test_suite_card.actions:
with test_suite_card.actions:
expand_toggle = testgen.expander_toggle(key=f"toggle_{key}")

profile_column, tests_column = st.columns([.5, .5])
Expand All @@ -90,54 +91,60 @@ def render_table_group_card(table_group: pd.Series, project_code: str, key: int)

with profile_column:
testgen.no_flex_gap()
profile_days_ago = (datetime.utcnow() - table_group["latest_profile_start"]).days
st.html(f"""<p class="caption">Latest profile {f'<span style="color: var(--error-color);">({profile_days_ago} days ago)</span>' if profile_days_ago > STALE_PROFILE_DAYS else ""}</p>""")
latest_profile_start = table_group["latest_profile_start"]

if (latest_profile_id := table_group["latest_profile_id"]) and not pd.isnull(latest_profile_id):
stale_message = ""
if pd.notnull(latest_profile_start) and (profile_days_ago := (datetime.utcnow() - latest_profile_start).days) > STALE_PROFILE_DAYS:
stale_message = f'<span style="color: var(--red);">({profile_days_ago} days ago)</span>'
testgen.caption(f"Latest profile {stale_message}")

if pd.notnull(latest_profile_start):
testgen.link(
label=date_service.get_timezoned_timestamp(st.session_state, table_group["latest_profile_start"]),
label=date_service.get_timezoned_timestamp(st.session_state, latest_profile_start),
href="profiling-runs:results",
params={ "run_id": str(latest_profile_id) },
key=f"overview:keys:go-to-profile:{latest_profile_id}",
params={ "run_id": str(table_group["latest_profile_id"]) },
key=f"overview:keys:go-to-profile:{table_group['latest_profile_id']}",
)

st.html(f"""
<b>{int(table_group["latest_anomalies_ct"])}</b> anomalies in <b>{int(table_group["latest_profile_table_ct"])}</b> tables
""")

testgen.summary_bar(
items=[
{ "label": "Definite", "value": int(table_group["latest_anomalies_definite_ct"]), "color": "red" },
{ "label": "Likely", "value": int(table_group["latest_anomalies_likely_ct"]), "color": "orange" },
{ "label": "Possible", "value": int(table_group["latest_anomalies_possible_ct"]), "color": "yellow" },
{ "label": "Dismissed", "value": int(table_group["latest_anomalies_dismissed_ct"]), "color": "grey" },
],
key=f"anomalies_{key}",
height=12,
width=280,
)
anomaly_count = to_int(table_group["latest_anomalies_ct"])
st.html(f"""
<b>{anomaly_count}</b> hygiene issues in <b>{to_int(table_group["latest_profile_table_ct"])}</b> tables
""")

if anomaly_count:
testgen.summary_bar(
items=[
{ "label": "Definite", "value": to_int(table_group["latest_anomalies_definite_ct"]), "color": "red" },
{ "label": "Likely", "value": to_int(table_group["latest_anomalies_likely_ct"]), "color": "orange" },
{ "label": "Possible", "value": to_int(table_group["latest_anomalies_possible_ct"]), "color": "yellow" },
{ "label": "Dismissed", "value": to_int(table_group["latest_anomalies_dismissed_ct"]), "color": "grey" },
],
key=f"anomalies_{key}",
height=12,
width=280,
)
else:
st.markdown("--")

with tests_column:
testgen.no_flex_gap()
st.caption("Latest test results")
total_tests = int(table_group["latest_tests_ct"]) if not pd.isnull(table_group["latest_tests_ct"]) else 0
total_tests = to_int(table_group["latest_tests_ct"])
if total_tests:
passed_tests = int(table_group["latest_tests_passed_ct"])
passed_tests = to_int(table_group["latest_tests_passed_ct"])

st.html(f"""
<p style="margin: -6px 0 8px;">{round(passed_tests * 100 / total_tests)}% passed</p>
<b>{total_tests}</b> tests in <b>{int(table_group["latest_tests_suite_ct"])}</b> test suites
<b>{total_tests}</b> tests in <b>{to_int(table_group["latest_tests_suite_ct"])}</b> test suites
""")

testgen.summary_bar(
items=[
{ "label": "Passed", "value": passed_tests, "color": "green" },
{ "label": "Warnings", "value": int(table_group["latest_tests_warning_ct"]), "color": "yellow" },
{ "label": "Failed", "value": int(table_group["latest_tests_failed_ct"]), "color": "red" },
{ "label": "Errors", "value": int(table_group["latest_tests_error_ct"]), "color": "brown" },
{ "label": "Dismissed", "value": int(table_group["latest_tests_dismissed_ct"]), "color": "grey" },
{ "label": "Warnings", "value": to_int(table_group["latest_tests_warning_ct"]), "color": "yellow" },
{ "label": "Failed", "value": to_int(table_group["latest_tests_failed_ct"]), "color": "red" },
{ "label": "Errors", "value": to_int(table_group["latest_tests_error_ct"]), "color": "brown" },
{ "label": "Dismissed", "value": to_int(table_group["latest_tests_dismissed_ct"]), "color": "grey" },
],
key=f"tests_{key}",
height=12,
Expand All @@ -148,10 +155,10 @@ def render_table_group_card(table_group: pd.Series, project_code: str, key: int)

if expand_toggle:
render_table_group_expanded(table_group["id"], project_code, key)


def render_table_group_expanded(table_group_id: str, project_code: str, key: int) -> None:
st.html('<hr style="margin: 8px 0 12px;">')
testgen.divider(8, 12)

column_spec = [0.25, 0.15, 0.15, 0.5]
suite_column, generation_column, run_column, results_column = st.columns(column_spec)
Expand All @@ -177,39 +184,41 @@ def render_test_suite_item(test_suite: pd.Series, column_spec: list[int], key: i
params={ "test_suite_id": str(test_suite["id"]) },
key=f"overview:keys:go-to-definitions:{test_suite['id']}",
)
st.html(f'<p class="caption" style="margin-top: -16px;">{test_suite["last_run_test_ct"]} tests</p>')
testgen.caption(f"{to_int(test_suite['last_run_test_ct'])} tests", "margin-top: -16px;")

if (latest_generation := test_suite["latest_auto_gen_date"]) and not pd.isnull(latest_generation):
generation_column.html(f'<p class="line">{date_service.get_timezoned_timestamp(st.session_state, latest_generation)}</p>')
else:
generation_column.markdown("--")
with generation_column:
if (latest_generation := test_suite["latest_auto_gen_date"]) and pd.notnull(latest_generation):
st.html(f'<p class="line">{date_service.get_timezoned_timestamp(st.session_state, latest_generation)}</p>')
else:
st.markdown("--")

latest_run_id = test_suite["latest_run_id"]
if latest_run_id and not pd.isnull(latest_run_id):
with run_column:
with run_column:
if (latest_run_start := test_suite["latest_run_start"]) and pd.notnull(latest_run_start):
testgen.link(
label=date_service.get_timezoned_timestamp(st.session_state, test_suite["latest_run_start"]),
label=date_service.get_timezoned_timestamp(st.session_state, latest_run_start),
href="test-runs:results",
params={ "run_id": str(latest_run_id) },
key=f"overview:keys:go-to-run:{latest_run_id}",
params={ "run_id": str(test_suite["latest_run_id"]) },
key=f"overview:keys:go-to-run:{test_suite['latest_run_id']}",
)
else:
st.markdown("--")

with results_column:
with results_column:
if to_int(test_suite["last_run_test_ct"]):
testgen.summary_bar(
items=[
{ "label": "Passed", "value": int(test_suite["last_run_passed_ct"]), "color": "green" },
{ "label": "Warnings", "value": int(test_suite["last_run_warning_ct"]), "color": "yellow" },
{ "label": "Failed", "value": int(test_suite["last_run_failed_ct"]), "color": "red" },
{ "label": "Errors", "value": int(test_suite["last_run_error_ct"]), "color": "brown" },
{ "label": "Dismissed", "value": int(test_suite["last_run_dismissed_ct"]), "color": "grey" },
{ "label": "Passed", "value": to_int(test_suite["last_run_passed_ct"]), "color": "green" },
{ "label": "Warnings", "value": to_int(test_suite["last_run_warning_ct"]), "color": "yellow" },
{ "label": "Failed", "value": to_int(test_suite["last_run_failed_ct"]), "color": "red" },
{ "label": "Errors", "value": to_int(test_suite["last_run_error_ct"]), "color": "brown" },
{ "label": "Dismissed", "value": to_int(test_suite["last_run_dismissed_ct"]), "color": "grey" },
],
key=f"tests_{key}",
height=8,
width=200,
)
else:
run_column.markdown("--")
results_column.html("--<br><br>")
else:
st.markdown("--")


def get_table_groups_summary(project_code: str) -> pd.DataFrame:
Expand Down
56 changes: 29 additions & 27 deletions testgen/ui/views/test_suites.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@
from testgen.commands.run_execute_tests import run_execution_steps_in_background
from testgen.commands.run_generate_tests import run_test_gen_queries
from testgen.commands.run_observability_exporter import export_test_results
from testgen.common import date_service
from testgen.ui.components import widgets as testgen
from testgen.ui.navigation.menu import MenuItem
from testgen.ui.navigation.page import Page
from testgen.ui.services.string_service import empty_if_null
from testgen.ui.session import session
from testgen.utils import to_int


class TestSuitesPage(Page):
Expand Down Expand Up @@ -66,7 +68,7 @@ def render(self, project_code: str | None = None, table_group_id: str | None = N
testgen.button(
type_="icon",
icon="output",
tooltip="Export results to observability",
tooltip="Export results to Observability",
tooltip_position="right",
on_click=partial(observability_export_dialog, test_suite),
key=f"test_suite:keys:export:{test_suite['id']}",
Expand All @@ -91,46 +93,46 @@ def render(self, project_code: str | None = None, table_group_id: str | None = N
main_section, latest_run_section, actions_section = st.columns([.4, .4, .2])

with main_section:
testgen.no_flex_gap()
testgen.link(
label=f"{test_suite['last_run_test_ct']} tests definitions",
label=f"{to_int(test_suite['last_run_test_ct'])} tests definitions",
href="test-suites:definitions",
params={ "test_suite_id": test_suite["id"] },
right_icon="chevron_right",
key=f"test_suite:keys:go-to-definitions:{test_suite['id']}",
)

st.html(f"""
<div>
<h6 style="padding: 0px; margin-bottom: 4px;">Description</h6>
<p style="margin: 0px;">{test_suite['test_suite_description']}</p>
</div>
""")

if (latest_run_start := test_suite["latest_run_start"]) and not pd.isnull(latest_run_start):
with latest_run_section:
testgen.no_flex_gap()
st.html('<h6 style="padding: 0px;">Latest Run</h6>')
testgen.caption("Description")
st.markdown(test_suite["test_suite_description"] or "--")

with latest_run_section:
testgen.no_flex_gap()
st.caption("Latest Run")

if (latest_run_start := test_suite["latest_run_start"]) and pd.notnull(latest_run_start):
testgen.link(
label=latest_run_start.strftime("%B %d, %H:%M %p"),
label=date_service.get_timezoned_timestamp(st.session_state, latest_run_start),
href="test-runs:results",
params={ "run_id": str(test_suite["latest_run_id"]) },
right_icon="chevron_right",
style="margin-bottom: 8px;",
height=29,
key=f"test_suite:keys:go-to-runs:{test_suite['id']}",
)
testgen.summary_bar(
items=[
{ "label": "Passed", "value": int(test_suite["last_run_passed_ct"]), "color": "green" },
{ "label": "Warnings", "value": int(test_suite["last_run_warning_ct"]), "color": "yellow" },
{ "label": "Failed", "value": int(test_suite["last_run_failed_ct"]), "color": "red" },
{ "label": "Errors", "value": int(test_suite["last_run_error_ct"]), "color": "brown" },
{ "label": "Dismissed", "value": int(test_suite["last_run_dismissed_ct"]), "color": "grey" },
],
height=20,
width=350,
key=f"test_suite:keys:run-rummary:{test_suite['id']}",
)
if to_int(test_suite["last_run_test_ct"]):
testgen.summary_bar(
items=[
{ "label": "Passed", "value": to_int(test_suite["last_run_passed_ct"]), "color": "green" },
{ "label": "Warnings", "value": to_int(test_suite["last_run_warning_ct"]), "color": "yellow" },
{ "label": "Failed", "value": to_int(test_suite["last_run_failed_ct"]), "color": "red" },
{ "label": "Errors", "value": to_int(test_suite["last_run_error_ct"]), "color": "brown" },
{ "label": "Dismissed", "value": to_int(test_suite["last_run_dismissed_ct"]), "color": "grey" },
],
height=20,
width=350,
key=f"test_suite:keys:run-rummary:{test_suite['id']}",
)
else:
st.markdown("--")

with actions_section:
testgen.button(
Expand Down

0 comments on commit e885361

Please sign in to comment.