-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded spec version and cargo file #204
Conversation
looks good, sorry laptop ran out of batteries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- - i'd like to have this PR docs: update docs with questions #205 reviewed and merged into this PR
- - if we or other users aren't able to use the chain specification or chain definition .json files (e.g. chain_def_local.json) that we've included in the chain-built folder, then they should be removed. PR docs: update docs with questions #205 proposes to remove 'dev' and 'local' chain spec and def files
- - it should include an answer to this unanswered question https://github.com/DataHighway-DHX/node/pull/205/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R396
- - i'd also like us to try running the Harbour network using five nodes, and confirm that it generates and finalizes blocks, and that another user is able to connect to the running chain by following our documentation, which means that following the steps all these guides should work, otherwise we should update them
https://dev.datahighway.com/docs/en/tutorials/tutorials-nodes-full-node-setup
https://dev.datahighway.com/docs/en/tutorials/tutorials-nodes-validator-setup
https://github.com/DataHighway-DHX/node/blob/master/EXAMPLES.md#testnet-standalone-harbour-pos-with-multiple-nodes- - - and we should also try doing this step to check it all works, but only checking that it works on Harbour Testnet instead of Westlake Mainnet https://github.com/DataHighway-DHX/node/blob/master/EXAMPLES.md#mainnet-standalone-westlake-pos-with-multiple-nodes-
…ime_version docs: update docs with questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propose to merge #204,
then check that this works on Harbour Testnet
https://dev.datahighway.com/docs/en/tutorials/tutorials-nodes-validator-setup
then release 3.0.5 when confirmed it works, otherwise do any fixes before release
No description provided.