Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_integration_aws] EXTERNAL_ID environment variable is now optional for import #2788

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[datadog_integration_aws] EXTERNAL_ID environment variable is now optional for import #2788

wants to merge 2 commits into from

Conversation

ecdatadog
Copy link
Contributor

Fixes #2257

The external_id field is a computed field that is :

  • never set outside of create => no risk of drift
  • never used for requesting Datadog API => no risk at the execution of actions

With the import block (tf 1.5+), needing an environment variable can be an issue => we put this environment variable as optional.

@ecdatadog ecdatadog requested review from a team as code owners January 21, 2025 15:58
@ecdatadog ecdatadog requested a review from a team as a code owner January 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datadog_aws_integration resource should support "import" block
2 participants
@ecdatadog @cswatt