Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff instead of black as formatter #3656

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@p-datadog
Copy link
Member

Can the trailing commas go back in?

@cbeauchesne
Copy link
Collaborator Author

Can the trailing commas go back in?

It's something that black has removed a while ago. We had them because we were using an old version of black (19.10b0 vs 24.10.0).

And both black and ruff formatters are very opinionated : barely no possible conf.

@cbeauchesne cbeauchesne marked this pull request as ready for review December 13, 2024 10:31
@cbeauchesne cbeauchesne requested review from a team and mabdinur as code owners December 13, 2024 10:31
@cbeauchesne cbeauchesne requested review from yahya-mouman and lievan and removed request for a team December 13, 2024 10:31
@cbeauchesne cbeauchesne merged commit 17673de into main Dec 13, 2024
428 of 431 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/ruff-format branch December 13, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants