Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parametric instability at container start #3359

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Oct 31, 2024

Motivation

On PARAMETRIC scenario, ports conflicts can prevent containers to start.

Changes

  • Use lower ports to prevent port collision
  • remove any hack that was made to mitigate the issue

Tests

Then only remove hacks, and redo 5 tests :

It makes 8 * 3 * 10 = 240 consecutive successful runs (1 parametric failure, but not related to port attribution)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review November 4, 2024 14:03
@cbeauchesne cbeauchesne requested review from mabdinur and a team as code owners November 4, 2024 14:03
@cbeauchesne cbeauchesne merged commit ad46fba into main Nov 4, 2024
300 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/simplify-parametric branch November 4, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant