Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RASP SQLi: enhance test & activate for Go #2574

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

Hellzy
Copy link
Contributor

@Hellzy Hellzy commented Jun 20, 2024

Summary

Modify the RASP SQLi tests to be a bit more activation friendly, and activate them for Go

Changes

  • Rename the test SQL table to users
  • Remove the optional ; from the resource check
  • Update the python endpoints to keep passing the tests
  • Activate the tests for go

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@Hellzy Hellzy changed the title rasp_sqli: rename table and remove extra semicolon RASP SQLi: enhance test & activate for Go Jun 20, 2024
@Hellzy Hellzy force-pushed the francois.mazeau/rasp_sqli branch from 93cd428 to 48aeef0 Compare June 20, 2024 08:25
@Hellzy Hellzy force-pushed the francois.mazeau/rasp_sqli branch from 48aeef0 to a819f02 Compare June 20, 2024 14:07
@Hellzy Hellzy marked this pull request as ready for review June 24, 2024 08:31
@Hellzy Hellzy requested review from a team as code owners June 24, 2024 08:31
@Hellzy Hellzy requested review from juanjux and erikayasuda June 24, 2024 08:31
@Hellzy Hellzy merged commit b803a4e into main Jun 24, 2024
319 checks passed
@Hellzy Hellzy deleted the francois.mazeau/rasp_sqli branch June 24, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants