Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.1 #2242

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Add Rails 7.1 #2242

merged 2 commits into from
Mar 20, 2024

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Mar 20, 2024

Motivation

missing coverage

Changes

add rails 7.1 on ruby 3.2 + rack 3 + puma 6

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I don't know a lot about system-tests, but can confirm this is effectively a copy paste of the Rails 7.0 image, updated to 7.1 and with Ruby 3.2.

Comment on lines +4 to +6


```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor:

Suggested change
```
```bash

@lloeki
Copy link
Member Author

lloeki commented Mar 20, 2024

effectively a copy paste

Yeah given the timing I outright copied the app code from 7.0, while in a perfect world this should be a brand new app as generated by rails new then later cleaned up to be minimal. Luckily 7.0 and 7.1 are quite close so that's not too much of a problem.

@lloeki
Copy link
Member Author

lloeki commented Mar 20, 2024

IIUC Rails 4.2 failure is solved by DataDog/dd-trace-rb#3541

@lloeki lloeki marked this pull request as ready for review March 20, 2024 14:59
@lloeki lloeki requested a review from a team March 20, 2024 14:59
@lloeki lloeki requested review from a team as code owners March 20, 2024 14:59
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's failing on some ruby runs, but I don't know if it's related ?

@lloeki
Copy link
Member Author

lloeki commented Mar 20, 2024

The rails42 ones are because of DataDog/dd-trace-rb#3542

The rails40 prod should be unrelated as well, it just failed to start the container for some reason and there's no reason it wouldn't start yet still start for all other scenarios + for dev on the same scenario.

@cbeauchesne
Copy link
Collaborator

ok, approving

@lloeki lloeki merged commit 0308a8c into main Mar 20, 2024
349 of 354 checks passed
@lloeki lloeki deleted the add-rails-71 branch March 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants