Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scenario and cases #2148

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add scenario and cases #2148

merged 1 commit into from
Feb 15, 2024

Conversation

anna-git
Copy link
Contributor

@anna-git anna-git commented Feb 14, 2024

Motivation

Activate scanners test for api security in dotnet

Changes

  • activate the dotnet test in the scenario file
  • cookies in dotnet can't contain spaces
  • allow other values as in aspnet core (dotnet) headers come like key - values [] so it generates such an api security schema with nested arrays.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@anna-git anna-git marked this pull request as ready for review February 14, 2024 17:59
@anna-git anna-git requested review from a team as code owners February 14, 2024 17:59
@anna-git anna-git merged commit f75142a into main Feb 15, 2024
172 of 184 checks passed
@anna-git anna-git deleted the anna/asm/activate-sec-apitest branch February 15, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants