Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conti/add aws kinesis tests #2143

Merged
merged 16 commits into from
Feb 16, 2024
Merged

Conti/add aws kinesis tests #2143

merged 16 commits into from
Feb 16, 2024

Conversation

wconti27
Copy link
Contributor

Motivation

More testing

Changes

Adds Kinesis cross integration tests, and implements endpoint for dd-trace-py

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@wconti27 wconti27 self-assigned this Feb 12, 2024
@wconti27 wconti27 marked this pull request as ready for review February 15, 2024 15:40
@wconti27 wconti27 requested a review from a team February 15, 2024 15:40
@wconti27 wconti27 requested review from a team as code owners February 15, 2024 15:40
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment

@wconti27 wconti27 merged commit 3369330 into main Feb 16, 2024
139 of 155 checks passed
@wconti27 wconti27 deleted the conti/add-aws-kinesis-tests branch February 16, 2024 14:24
@@ -19,6 +19,8 @@ ENV _DD_APPSEC_DEDUPLICATION_ENABLED=false
ENV DD_BOTOCORE_PROPAGATION_ENABLED=true
ENV DD_KAFKA_PROPAGATION_ENABLED=true

ENV LOG_LEVEL='DEBUG'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing lot of flakiness on the python tracer, we removed this line a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants