Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check variant names in manifest validation #2082

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Jan 29, 2024

Motivation

Prevent typos

Changes

Validate that variant names in manifest files really exists (and correct a typo in java manifest)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/validate-variant-names branch from 648fa45 to a71de69 Compare January 29, 2024 15:09
@cbeauchesne cbeauchesne marked this pull request as ready for review January 29, 2024 15:22
@cbeauchesne cbeauchesne requested review from a team as code owners January 29, 2024 15:22
@cbeauchesne cbeauchesne merged commit 554b2c9 into main Jan 29, 2024
6 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/validate-variant-names branch January 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant