Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Support unified package #1862

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

Anilm3
Copy link
Contributor

@Anilm3 Anilm3 commented Nov 22, 2023

Description

Currently the system tests (with the exception of the parametric tests) use the independent tracer and appsec packages, this PR adds support for the unified package to allow local testing and testing in the tracer's CI.

Related Jira: APPSEC-4581

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@Anilm3 Anilm3 marked this pull request as ready for review November 22, 2023 16:18
@Anilm3 Anilm3 requested review from a team as code owners November 22, 2023 16:18
@Anilm3
Copy link
Contributor Author

Anilm3 commented Nov 22, 2023

Note that this new script was tested locally and in the tracer's CI and it worked as expected, i.e. the combined package with the dev version of all extensions was used and passes all the tests.

@cbeauchesne cbeauchesne self-requested a review November 23, 2023 08:29
@Anilm3 Anilm3 merged commit 7978630 into main Nov 23, 2023
@Anilm3 Anilm3 deleted the anilm3/support-unified-php-package branch November 23, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants