-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleep mode for scenarios #1794
Sleep mode for scenarios #1794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By which wizardry it actually sleeps ?
Also, could you remove the sleep
scenario in _scenarios.py
?
if the option --sleep is set, in the method "pytest_collection_modifyitems" we are deselecting the tests/items associated with the real scenario (ie INTEGRATIONS) and adding "SLEEP" scenario items. So I think , in this way we can't remove the sleep scenario |
Ah, ok ! I think we could to this a little bit better : in
And then, we can remove the sleep scenario :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again a small leftover in _scneario.py to remove : the sleep scenario instance.
Uppss! Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should communicate this on apm-shared-testing
🎉
Description
Enable sleep mode for different scenarios
Motivation
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario
,run-profiling-scenario
...). If this PR modifies any system-tests internal, then add therun-all-scenarios
label (more info).build-some-image
label is present