Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Add spring-boot-payara variant #1287

Merged
merged 8 commits into from
Jun 26, 2023
Merged

[java] Add spring-boot-payara variant #1287

merged 8 commits into from
Jun 26, 2023

Conversation

smola
Copy link
Member

@smola smola commented Jun 22, 2023 •
edited
Loading

Description

Motivation

Reviewer checklist

  • If this PR modifies anything else than strictly the default scenario, then remove the run-default-scenario label
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Remove the run-default-scenario label to run all scenarios (more info)

Once your PR is reviewed, you can merge it! ❤️

@smola smola added java Pull requests that update Java code and removed run-default-scenario labels Jun 22, 2023
@smola smola changed the title [WIP] Add spring-boot-payara variant Add spring-boot-payara variant Jun 22, 2023
@smola smola changed the title Add spring-boot-payara variant [java] Add spring-boot-payara variant Jun 22, 2023
@smola smola marked this pull request as ready for review June 23, 2023 08:49
@smola smola requested review from a team as code owners June 23, 2023 08:49
@smola smola merged commit 515310b into main Jun 26, 2023
@smola smola deleted the smola/payara branch June 26, 2023 09:07
@smola smola mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

Assignees
No one assigned
Labels
java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smola @manuel-alvarez-alvarez @cbeauchesne