Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nodejs tests #1112

Merged
merged 51 commits into from
May 25, 2023
Merged

Update nodejs tests #1112

merged 51 commits into from
May 25, 2023

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Apr 24, 2023 •
edited
Loading

Description

  • Fix a typo in the doc
  • Fix the wrong function name used in weblog routes doc
  • Add version numbers and skips for nodejs tests
  • Fix 2 typo in name of a test
  • Update the blocking template tests to allow non newline files
  • Add entry in .gitignore for nodejs

Motivation

Additional notes

@simon-id simon-id self-assigned this Apr 24, 2023
@simon-id simon-id mentioned this pull request May 23, 2023
Closed
@simon-id simon-id marked this pull request as ready for review May 24, 2023 09:46
@simon-id simon-id requested review from a team as code owners May 24, 2023 09:46
@simon-id simon-id merged commit 86e92d6 into main May 25, 2023
@simon-id simon-id deleted the update_nodejs_tests branch May 25, 2023 14:41
ida613 pushed a commit that referenced this pull request Jun 23, 2023
@simon-id @ida613
Update nodejs tests (#1112)
b9d7b49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@uurien uurien uurien approved these changes

@ameske ameske ameske approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@christophe-papazian christophe-papazian christophe-papazian approved these changes

Assignees

@simon-id simon-id

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simon-id @smola @uurien @ameske @cbeauchesne @christophe-papazian