Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom rules in embedded file #1076

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Add custom rules in embedded file #1076

merged 4 commits into from
Apr 25, 2023

Conversation

anna-git
Copy link
Contributor

@anna-git anna-git commented Apr 14, 2023

Description

Custom rules in appsec custom file. Should work with waf > 1.9.0,
Part of the scenario APPSEC_CUSTOM_RULES

@anna-git anna-git marked this pull request as ready for review April 16, 2023 20:57
@anna-git anna-git requested a review from a team as a code owner April 16, 2023 20:57
@anna-git anna-git force-pushed the anna/custom_rules_in_file branch from db2ea7f to c3aa1c0 Compare April 16, 2023 21:05
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on dotnet on this scenario

@cbeauchesne cbeauchesne marked this pull request as draft April 19, 2023 09:55
@anna-git anna-git marked this pull request as ready for review April 20, 2023 14:08
@anna-git
Copy link
Contributor Author

CI is failing on dotnet on this scenario

Yes! The test should pass from tracer 2.30.0 and not 2.29.0 like I first added 🤦, it's changed now

@anna-git anna-git requested a review from cbeauchesne April 21, 2023 13:58
@anna-git anna-git merged commit 9b92e30 into main Apr 25, 2023
@anna-git anna-git deleted the anna/custom_rules_in_file branch April 25, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants